Will now throw LibGit2SharpException with proper message when 'user.name... #831
Conversation
There was a problem hiding this comment.
We've already made sure that neither the name or email are null or empty. Shouldn't we get rid of the null handling here?
There was a problem hiding this comment.
All the null/empty value handling is within the if (shouldThrowIfNotFound) block. When that flag is turned off, the code you highlighted should still fall back to the defaults in case of null/empty values in settings.
|
@jaccus Neat! Could you please rebase onto vNext and reword your first line of the commit message so that it's a bit more terse (we usually prefer them to be 50 chars or less)? Maybe something like Once this is done, we'll happily merge this PR ✨ : |
When global user.name or user.email is set to an empty value, it will now throw a LibGit2SharpException with proper explanatory message. Previously it would throw an ArgumentException with obscure message: "String cannot be empty\nParameter name: name".
|
Amended the commit message and rebased. |
|
Thanks! 👍 |
3 participants
...' or 'user.email' global setting is set to an empty value
When global user.name or user.email is set to an empty value, it will
now throw a LibGit2SharpException with proper explanatory message.
Previously it would throw an ArgumentException with obscure message:
"String cannot be empty\nParameter name: name".